Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: View classes to fix PHPStan errors #8208

Merged
merged 3 commits into from
Nov 16, 2023
Merged

refactor: View classes to fix PHPStan errors #8208

merged 3 commits into from
Nov 16, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 14, 2023

Description

  • refactor

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Nov 14, 2023
@kenjis kenjis merged commit 46ac972 into codeigniter4:develop Nov 16, 2023
61 checks passed
@kenjis kenjis deleted the refactor-View-classes branch November 16, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @paulbalandan